On 10/28/2013 05:06 PM, Mark Brown wrote:
On Mon, Oct 28, 2013 at 11:53:14AM +0000, Liam Girdwood wrote:
On Fri, 2013-10-25 at 13:42 +0300, Jarkko Nikula wrote:
Yes, I don't see any urgent reason to push this hack in. Better to check dev_name change first. What I'm going to propose there is "spix.y" to "spi-INTABCD:xy" and "x-00yz" to "i2c-INTABCD:xy"
We probably need to be able to match on ACPI name alone as some BIOS settings can change the I2C bus number and break the name match used at bind time. e.g. on Haswell the codec can either be on I2C bus 0 or 7.
Indeed. The way I initially read the suggestion above the idea was to replace the bus number with the ACPI name for the device which seemed sensible but now I reread the bus number is still there.
Sorry, my textual proposal above was confusing and should have used different variables for ACPI name. What I meant was "spix.y" -> "spi-INTABCD:ij" and "x-00yz" to "i2c-INTABCD:ij" where "INTABCD:ij" was the ACPI device name which contains the device instance in "ij".