Re: [alsa-devel] [PATCH v5 2/4] ALSA: compress: Add function to indicate the stream has gone bad

• • snd_compr_stop_error: Report a fatal error on a stream
• • @stream: pointer to stream
• • @state: state to transition the stream to
• • Stop the stream and set its state.
• • Should be called with compressed device lock held.
• */

+int snd_compr_stop_error(struct snd_compr_stream *stream,

• 	 snd_pcm_state_t state)
  

+{

• if (stream->runtime->state == state)

• return 0;
  

• stream->runtime->state = state;

Minor nit-pick: should there be a consistency check to make sure the new state makes sense - or maybe just a log to help debug? e.g. XRUN should only come if the state in run or draining stages, applying the new state unconditionally could lead to issues. And question for my education since I see no lock/mutex: is the state always consistent or is there a risk of this state being changed while some other thread or interrupt handling modifies it was well?