On Tue, 22 Mar 2016 15:41:53 +0100, Takashi Iwai wrote:
On Tue, 22 Mar 2016 15:31:03 +0100, Lu, Han wrote:
- Add tinyalsa support, configure will read environment and decide to
link to ALSA lib or tinyalsa lib.
It's not good to choose tinyalsa forcibly whenever it's found. Then there is no way to build alsabat with alsa-lib on a system that have both libraries installed.
Better to add configure option to choose the backend, not only detecting it.
OK. I added configure option "--enable-tinyalsa", and by default tinyalsa is disabled. I submitted patch v2 and please help to review.
IMO, something like --with-backend=$TYPE is better. It's not intuitive that --enable-xxx is mutual exclusive with another option.
On the second thought, --with-backend sounds too ambiguous for the configure script that governs the whole alsa-utils programs. If any, it should be like --with-alsabat-backend=xxx.
Or, maybe it's not too bad to use --enable, but then again the option name should be more specific to alsabat.
It's a bike shed story, so I don't mind so much about it. If you have a strong preference, let me know.
Takashi