Re: [PATCH] ASoC: amd: Replacing component->name with codec_dai->name

On Fri, Aug 07, 2020 at 08:36:25AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote:

On Thu, Aug 06, 2020 at 03:44:12PM +0530, Ravulapati Vishnu vardhan rao wrote:

...

Replacing string compare with codec_dai->name instead of comparing with codec_dai->component->name in hw_params.

...

Why?

Here the component name for codec RT1015 is "i2c-10EC1015:00" and will never be "rt1015-aif1" As it is codec-dai->name so the strcmp always compares and fails to set the sysclk,pll,bratio of expected codec-dai

This should be in the changelog so people can understand why the change was made.

Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to.