On 02/12/2021 22:56, Andy Shevchenko wrote:
GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove assignment here.
Thanks, looks good, Acked-by: Peter Ujfalusi peter.ujfalusi@gmail.com
For the details one may look into the of_gpio_dev_init() implementation.
Which works after commit 1df62542e0161.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
sound/soc/ti/davinci-mcasp.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c index 56a19eeec5c7..81c1ccec5904 100644 --- a/sound/soc/ti/davinci-mcasp.c +++ b/sound/soc/ti/davinci-mcasp.c @@ -2230,9 +2230,6 @@ static int davinci_mcasp_init_gpiochip(struct davinci_mcasp *mcasp) mcasp->gpio_chip = davinci_mcasp_template_chip; mcasp->gpio_chip.label = dev_name(mcasp->dev); mcasp->gpio_chip.parent = mcasp->dev; -#ifdef CONFIG_OF_GPIO
- mcasp->gpio_chip.of_node = mcasp->dev->of_node;
-#endif
return devm_gpiochip_add_data(mcasp->dev, &mcasp->gpio_chip, mcasp); }