Re: [PATCH 3/3] snd-usb-6fire: Unmark struct snd_pcm_hardware const

On Tue, 21 Jul 2020 08:48:53 +0200, René Herman wrote:

struct snd_pcm_hardware pcm_hw is in fact changed in usb6fire_pcm_open()

This must be superfluous. usb6fire_pcm_open() changes the field of the copied pcm_hw, not the original pcm_hw itself. Otherwise we must have got already a compile warning / error.

thanks,

Takashi

Signed-off-by: René Herman rene.herman@gmail.com

pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pcm.c b/pcm.c index cce1312..8ccf638 100644 --- a/pcm.c +++ b/pcm.c @@ -40,7 +40,7 @@ enum { /* pcm streaming states */ STREAM_STOPPING };

-static const struct snd_pcm_hardware pcm_hw = { +static struct snd_pcm_hardware pcm_hw = { .info = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER | -- 2.17.1