9 Nov
2016
9 Nov
'16
1:47 a.m.
Hi Russell
@@ -11,4 +11,11 @@ struct dw_hdmi_audio_data { u8 *eld; };
+struct dw_hdmi_i2s_audio_data {
- struct dw_hdmi *hdmi;
- void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
- u8 (*read)(struct dw_hdmi *hdmi, int offset);
+};
Another slight concern here is why we need this separate data for i2s - maybe adding the write/read ops to struct dw_hdmi_audio_data would be a better thing to do, which would then allow the AHB audio to drop the .base argument in the future.
I'm not that bothered about this though. So...
Thank you for your feedback. Maybe we can merge these in incremental patch if needed ?