On 10/09/2014 18:06, Jean-Francois Moine wrote:
On Wed, 10 Sep 2014 13:43:06 +0200 Benoit Cousson bcousson@baylibre.com wrote:
codec@0 {sound-dai = <&hdmi 0>;};codec@1 {sound-dai = <&spdif_codec>; };I don't have strong opinion on that, but in my case, I was considering using a simple list instead of several nodes. I don't like having to add fake address just to ensure uniqueness.
Something like that:
sound-dais = <&spdif_codec 1>, <&hdmi 0>;
You are right, this would be simpler (I did not see that there could be phandle's with different cell sizes in a list).
In fact you cannot, that why I added the same number of parameters for both.
For DT, it is just a list of elements, it could be encoded like that: <&spdif_codec 1 &hdmi 0>;
At the end it will be a list of u32 inside the dtb.
BTW, what is that extra parameter after the phandle? I cannot find any reference of that inside the Documentation.
If we need to have a random number of parameters after the code-dai phandle, we couldn't use that list.
That being said, it will require changing the name with a plural form, and ensuring we have the same number of parameters for each codec.
But I don't think that changing the name could be useful: the treatment is exactly the same and, as a result, all CODEC DAIs go to the DAI list of the DAI link.
Yeah, maybe not that useful, but that was just to be aligned with similar cases in DT bindings. Like gpios, interrupts...
Regards, Benoit