On Thu, Apr 25, 2013 at 11:35:20AM +0800, Shawn Guo wrote:
On Wed, Apr 24, 2013 at 09:45:40PM +0200, Sascha Hauer wrote:
Hi Markus,
On Wed, Apr 24, 2013 at 04:36:30PM +0200, Markus Pargmann wrote:
Add devicetree support for this audio soc fabric driver.
@@ -32,8 +35,12 @@ static struct snd_soc_dai_link imx_phycore_dai_ac97[] = { .stream_name = "HiFi", .codec_dai_name = "wm9712-hifi", .codec_name = "wm9712-codec", +#ifdef CONFIG_MACH_IMX27_DT
.platform_name = "imx-fiq-pcm-audio",+#else .cpu_dai_name = "imx-ssi.0", .platform_name = "imx-fiq-pcm-audio.0", +#endif
This doesn't work properly. Compiling the kernel with IMX27_DT enabled does not necessarily mean that it also started with dt support.
Right, we should run-time check pdev->dev.of_node to see if it's a DT boot and set .platform_of_node rather than .platform_name if it is. But it's only possible with the cleanup series "ASoC: fsl: imx-pcm driver cleanup" I just sent being the base. I hope you can rebase your series on that :)
The current version of phycore-ac97.c is not a driver, it is just a late init call. So run-time check is not possible unless I modify the old part to be a driver and add a device to all board init functions using ac97. (I would prefer dropping the non-DT part in this case ;) )
Yes I rebased this series onto your cleanups, looks good so far and platform_of_node works finally.
Thanks,
Markus
Shawn
Personally I am fine with removing platform based support for this driver if it's too much effort to fix it properly, but we shouldn't start working with ifdefs here.
Sascha
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |