On 2016年11月30日 00:22, Takashi Iwai wrote:
On Tue, 29 Nov 2016 16:15:57 +0100,
--- a/src/pcm/pcm_file.c 2013-07-08 14:31:36.000000000 +0200 +++ b/src/pcm/pcm_file.c 2015-05-04 16:26:10.413615403 +0200 @@ -698,6 +698,7 @@ .readi = snd_pcm_file_readi, .readn = snd_pcm_file_readn, .avail_update = snd_pcm_generic_avail_update,
- .htimestamp = snd_pcm_generic_htimestamp, .mmap_commit = snd_pcm_file_mmap_commit, .poll_descriptors_count = snd_pcm_generic_poll_descriptors_count, .poll_descriptors = snd_pcm_generic_poll_descriptors,
I oppose this application, because designated initialization is already applied to the .htimestamp member.
... .poll_descriptors = snd_pcm_generic_poll_descriptors, .poll_revents = snd_pcm_generic_poll_revents, .htimestamp = snd_pcm_generic_htimestamp,
Oops, 'snd_pcm_generic_real_htimestamp' is proper here...
};
Please see below commit: pcm:file: add the missing htimestamp callback http://git.alsa-project.org/?p=alsa-lib.git;a=commit;h=68ae0c72a53704d416fe7...
This mistake causes below warning with -Woverride-init option. pcm_file.c:714:16: warning: initialized field overwritten [-Woverride-init] .htimestamp = snd_pcm_generic_real_htimestamp, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I guess mentor/ADIT developers works for former snapshot, then missed to rebase to current mainline of alsa-lib. I suggest them to di re-evaluation with current mainline without this patch.
I overlooked it, too. Now the commit got reverted.
Thanks.
Takashi Sakamoto