Re: [alsa-devel] [PATCH] hda: add HP automute support to Intel ALC889/ALC889A models

At Thu, 30 Jul 2009 14:47:25 +0800, Wu Fengguang wrote:

+static struct hda_verb alc262_hippo_unsol_verbs[] = {

• {0x15, AC_VERB_SET_UNSOLICITED_ENABLE, AC_USRSP_EN | ALC880_HP_EVENT},
• {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP},
• {}

+};

I don't think it's good to move alc262 stuff into the middle of alc88x. Rather define a common content, e.g. alc_pin15_hp_automute_verbs[], and use it in all places. Or, to reduce the patch size, you can simply #define alc262_hippo_unsol_verbs alc_pin15_hp_automute_verbs

thanks,

Takashi