Hi Radoslaw,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next] [also build test WARNING on sound/for-next v5.7-rc3 next-20200501] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Radoslaw-Biernacki/ASoC-Intel-board... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot lkp@intel.com
Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
sound/soc/intel/boards/skl_nau88l25_max98357a.c: In function 'platform_clock_control':
sound/soc/intel/boards/skl_nau88l25_max98357a.c:56:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
int ret; ^~~
vim +/ret +56 sound/soc/intel/boards/skl_nau88l25_max98357a.c
0ab338ff33762d Sathyanarayana Nujella 2016-02-24 49 8eaf2b31dd316f Rohit Ainapure 2015-12-11 50 static int platform_clock_control(struct snd_soc_dapm_widget *w, 8eaf2b31dd316f Rohit Ainapure 2015-12-11 51 struct snd_kcontrol *k, int event) 8eaf2b31dd316f Rohit Ainapure 2015-12-11 52 { 8eaf2b31dd316f Rohit Ainapure 2015-12-11 53 struct snd_soc_dapm_context *dapm = w->dapm; 8eaf2b31dd316f Rohit Ainapure 2015-12-11 54 struct snd_soc_card *card = dapm->card; 8eaf2b31dd316f Rohit Ainapure 2015-12-11 55 struct snd_soc_dai *codec_dai; 8eaf2b31dd316f Rohit Ainapure 2015-12-11 @56 int ret; 8eaf2b31dd316f Rohit Ainapure 2015-12-11 57 dfb6ec7ae57d33 Pierre-Louis Bossart 2017-10-12 58 codec_dai = snd_soc_card_get_codec_dai(card, SKL_NUVOTON_CODEC_DAI); 8eaf2b31dd316f Rohit Ainapure 2015-12-11 59 if (!codec_dai) { 8eaf2b31dd316f Rohit Ainapure 2015-12-11 60 dev_err(card->dev, "Codec dai not found; Unable to set platform clock\n"); 8eaf2b31dd316f Rohit Ainapure 2015-12-11 61 return -EIO; 8eaf2b31dd316f Rohit Ainapure 2015-12-11 62 } 8eaf2b31dd316f Rohit Ainapure 2015-12-11 63 4adaffea05f2fa Radoslaw Biernacki 2020-05-01 64 if (!SND_SOC_DAPM_EVENT_ON(event)) { 8eaf2b31dd316f Rohit Ainapure 2015-12-11 65 ret = snd_soc_dai_set_sysclk(codec_dai, 8eaf2b31dd316f Rohit Ainapure 2015-12-11 66 NAU8825_CLK_INTERNAL, 0, SND_SOC_CLOCK_IN); 8eaf2b31dd316f Rohit Ainapure 2015-12-11 67 if (ret < 0) { 8eaf2b31dd316f Rohit Ainapure 2015-12-11 68 dev_err(card->dev, "set sysclk err = %d\n", ret); 8eaf2b31dd316f Rohit Ainapure 2015-12-11 69 return -EIO; 8eaf2b31dd316f Rohit Ainapure 2015-12-11 70 } 8eaf2b31dd316f Rohit Ainapure 2015-12-11 71 } 8eaf2b31dd316f Rohit Ainapure 2015-12-11 72 8eaf2b31dd316f Rohit Ainapure 2015-12-11 73 return ret; 8eaf2b31dd316f Rohit Ainapure 2015-12-11 74 } 8eaf2b31dd316f Rohit Ainapure 2015-12-11 75
:::::: The code at line 56 was first introduced by commit :::::: 8eaf2b31dd316ff5ffbdad14853d2bf8779bab13 ASoC: Intel: Skylake: Add Nuvoton Maxim machine driver
:::::: TO: Rohit Ainapure rohit.m.ainapure@intel.com :::::: CC: Mark Brown broonie@kernel.org
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org