Re: [alsa-devel] [PATCH 1/3] ASoC: compress: Only call free for components which have been opened

On Tue, Apr 24, 2018 at 04:39:01PM +0100, Charles Keepax wrote:

The core should only call free on a component if said component has already had open called on it. This is not presently the case and most compressed drivers in the kernel assume it will be. This causes null pointer dereferences in the drivers as they attempt clean up for stuff that was never put in place.

This is fixed by aborting calling open callbacks once a failure is encountered and then during clean up only iterating through the component list to that point.

Acked-by: Vinod Koul vkoul@kernel.org