On Tue, 2013-06-04 at 16:54 -0400, Alan Stern wrote:
I don't see how DEFAULT_DEBUG_LEVEL can be used to optimize away anything. The user can always change the value of the "debug" module parameter while the system is running. The only valid opportunity for optimization would be if CONFIG_SND_DEBUG was disabled; then all these messages would disappear.
Not really.
Think of CONFIG_SND_DEBUG as a level. (0, 1, 2) or maybe think of it as CONFIG_SND_DEBUG_VERBOSITY.
There could still be ability to have CONFIG_SND_DEBUG limit the compiled-in messages to those below the #define value and still then have runtime control over which ones are displayed.
You didn't respond to the first point I raised. Since these messages are all meant for debugging, there's no point allowing them to have prefixes like KERN_ERR or KERN_INFO. They should always be printed at the KERN_DEBUG level. Or did you think this was so obviously true that it didn't require any comment?
Yes. My perspective is _all_ debugging messages should be at KERN_DEBUG.