23 Sep
2013
23 Sep
'13
5:56 a.m.
Hi Nicolin,
On Sun, Sep 22, 2013 at 11:13 PM, Nicolin Chen b42378@freescale.com wrote:
In freescale internal branch, I had a patch to drop this part of code because the hw_params() in fsl_ssi.c is already considering about the wl configuration, so it won't change the wl value even if two streams' sample bits are different.
But if we think about the benefit of snd_pcm_hw_constraint() for a case like "(arecord -d10 xx.wav &);sleep 1;aplay yy.wav", yea the non-simultaneous case, we might also just turn the dev_err() into dev_warn() from my point of view:
if (first_runtime->sample_bits) snd_pcm_hw_constraint_minmax(substream->runtime, SNDRV_PCM_HW_PARAM_SAMPLE_BITS, first_runtime->sample_bits, first_runtime->sample_bits); else dev_warn(substream->pcm->card->dev, "Not enforcing sample bits due to race\n");
You can try this two solutions and find a better one.
Yes, tried both and none of them worked for me.
Could you try linux-next if you have a chance?
Thanks,
Fabio Estevam