On 4/6/23 13:28, Curtis Malainey wrote:
On Thu, Apr 6, 2023 at 10:19 AM Mark Brown broonie@kernel.org wrote:
On Thu, Apr 06, 2023 at 10:50:26AM -0500, Pierre-Louis Bossart wrote:
From: Curtis Malainey cujomalainey@chromium.org
Convert all existing calls that pass "NULL, 0" for reply data to the new no_reply calls. Also convert any calls that pass in data but don't actually parse the result.
This breaks an x86 allmodconfig build:
This is because a9737808b3e4 ("ASoC: SOF: compress: Set compress data offset") was sent first. Pierre, how do you want to resolve this?
Ah yes, this upstream patch is unfortunately not the one we have in our tree [1], so the dependency was missed. We'll have to insist that all SOF contributors send patches 'as-is' from the same topic/sof-dev-rebase branch, and add allmodconfig to our CI and checklist.
Mark, please drop this version, we'll have to resend a v2 next week. Sorry about the noise.
[1] https://github.com/thesofproject/linux/commit/bfdc6b889069aab631af7b7c485f24...
/build/stage/linux/sound/soc/sof/compress.c: In function ‘sof_compr_set_params’: /build/stage/linux/sound/soc/sof/compress.c:238:46: error: ‘ipc_params_reply’ undeclared (first use in this function); did you mean ‘sof_ipc_pcm_params_reply’? 238 | ipc_params_reply.posn_offset); | ^~~~~~~~~~~~~~~~ | sof_ipc_pcm_params_reply /build/stage/linux/sound/soc/sof/compress.c:238:46: note: each undeclared identifier is reported only once for each function it appears in