Hi Vijendar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on asoc/for-next] [also build test ERROR on v5.13 next-20210701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vijendar-Mukunda/ASoC-add-dai_reode... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: i386-randconfig-r031-20210705 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/a132ec819f3d15c103f3afb5f3e8154355fa... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vijendar-Mukunda/ASoC-add-dai_reoder-flag-to-reverse-the-stop-sequence/20210705-234319 git checkout a132ec819f3d15c103f3afb5f3e8154355fafdfc # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
sound/soc/soc-pcm.c: In function 'soc_pcm_trigger':
sound/soc/soc-pcm.c:1019:3: error: expected expression before 'struct'
1019 | + struct snd_soc_card *card = rtd->card; | ^~~~~~ sound/soc/soc-pcm.c:1020:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1020 | int ret = -EINVAL, _ret = 0; | ^~~
sound/soc/soc-pcm.c:1060:7: error: 'card' undeclared (first use in this function)
1060 | if (card->dai_reorder) { | ^~~~ sound/soc/soc-pcm.c:1060:7: note: each undeclared identifier is reported only once for each function it appears in sound/soc/soc-pcm.c:1018:30: warning: unused variable 'rtd' [-Wunused-variable] 1018 | struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); | ^~~
vim +/struct +1019 sound/soc/soc-pcm.c
1015 1016 static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) 1017 { 1018 struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
1019 + struct snd_soc_card *card = rtd->card;
1020 int ret = -EINVAL, _ret = 0; 1021 int rollback = 0; 1022 1023 switch (cmd) { 1024 case SNDRV_PCM_TRIGGER_START: 1025 case SNDRV_PCM_TRIGGER_RESUME: 1026 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 1027 ret = snd_soc_link_trigger(substream, cmd, 0); 1028 if (ret < 0) 1029 goto start_err; 1030 1031 ret = snd_soc_pcm_component_trigger(substream, cmd, 0); 1032 if (ret < 0) 1033 goto start_err; 1034 1035 ret = snd_soc_pcm_dai_trigger(substream, cmd, 0); 1036 start_err: 1037 if (ret < 0) 1038 rollback = 1; 1039 } 1040 1041 if (rollback) { 1042 _ret = ret; 1043 switch (cmd) { 1044 case SNDRV_PCM_TRIGGER_START: 1045 cmd = SNDRV_PCM_TRIGGER_STOP; 1046 break; 1047 case SNDRV_PCM_TRIGGER_RESUME: 1048 cmd = SNDRV_PCM_TRIGGER_SUSPEND; 1049 break; 1050 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 1051 cmd = SNDRV_PCM_TRIGGER_PAUSE_PUSH; 1052 break; 1053 } 1054 } 1055 1056 switch (cmd) { 1057 case SNDRV_PCM_TRIGGER_STOP: 1058 case SNDRV_PCM_TRIGGER_SUSPEND: 1059 case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
1060 if (card->dai_reorder) {
1061 ret = snd_soc_pcm_component_trigger(substream, cmd, rollback); 1062 if (ret < 0) 1063 break; 1064 1065 ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback); 1066 if (ret < 0) 1067 break; 1068 } else { 1069 ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback); 1070 if (ret < 0) 1071 break; 1072 1073 ret = snd_soc_pcm_component_trigger(substream, cmd, rollback); 1074 if (ret < 0) 1075 break; 1076 } 1077 ret = snd_soc_link_trigger(substream, cmd, rollback); 1078 break; 1079 } 1080 1081 if (_ret) 1082 ret = _ret; 1083 1084 return ret; 1085 } 1086
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org