Re: [alsa-devel] [PATCH 2/3] ASoC: fsl_utils: fix a leaked reference by adding missing of_node_put

5 Apr 2019


      ...
@@ -71,6 +71,7 @@  int fsl_asoc_get_dma_channel(struct device_node *ssi_np,
   iprop = of_get_property(dma_np, "cell-index", NULL);
   if (!iprop) {
   	of_node_put(dma_np);

of_node_put(dma_channel_np);

return -EINVAL;
}
*dma_id = be32_to_cpup(iprop);

How do you think about to adjust the exception handling in this function
implementation a bit more according to the Linux coding style?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sou...
Regards,
Markus

    

Markus Elfring