Re: [alsa-devel] [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec

At Fri, 14 Dec 2007 12:48:00 -0400, Andrew Paprocki wrote:

AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the Intel HDA spec, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f mask.

Signed-off-by: Andrew Paprocki andrew@ishiboo.com

Applied to HG tree now. Thanks.

Takashi

diff -r 4a204306b295 -r 3681a8bf780e pci/hda/hda_codec.h --- a/pci/hda/hda_codec.h Fri Dec 14 14:42:41 2007 +0100 +++ b/pci/hda/hda_codec.h Fri Dec 14 12:27:35 2007 -0500 @@ -234,7 +234,7 @@ enum {

/* Volume knobs capabilities */ #define AC_KNBCAP_NUM_STEPS (0x7f<<0) -#define AC_KNBCAP_DELTA (1<<8) +#define AC_KNBCAP_DELTA (1<<7)

/*

• Control Parameters

---

Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel