On Sat, May 13, 2023 at 08:08:05PM +0200, Krzysztof Kozlowski wrote:
On 12/05/2023 18:18, Charles Keepax wrote:
On Fri, May 12, 2023 at 05:25:52PM +0200, Krzysztof Kozlowski wrote:
On 12/05/2023 14:28, Charles Keepax wrote:
The CS42L43 is an audio CODEC with integrated MIPI SoundWire interface (Version 1.2.1 compliant), I2C, SPI, and I2S/TDM interfaces designed for portable applications. It provides a high dynamic range, stereo DAC for headphone output, two integrated Class D amplifiers for
...
- interrupt-controller: true
- '#interrupt-cells':
- const: 2
Hm, are you sure? Who is the consumer/user of this interrupt controller?
Anyone who wants the device has GPIOs that can signal IRQs. Some of the other IRQs could be more generally useful, such as some of the jack detection ones.
OK, makes sense, but it is a bit odd then to have: codec { which is GPIO and interrupt controller, but not pin controller pinctrl { pin controller, which is not GPIO and not interrupt controller } } Maybe all the GPIO/pin/related interrupt properties should be moved to pinctrl node?
I will have a look at that although I have a vague memory that this made the pinctrl very sad doing this. Presumably a bug somewhere but might take me a while to figure that out. The interrupt controller is a bit of a grey area as well since it has a bunch of IRQs that don't relate to the pins as well as some that do. So logically it might be better suited on the root node.
Thanks, Charles