Hi Takashi,
On 29.11.2017 15:49, Takashi Sakamoto wrote:
Hi,
On Nov 29 2017 22:43, Maciej S. Szmigiero wrote:
This format is similar to an existing 20-bit PCM format SNDRV_PCM_FORMAT_{S,U}20_3, however it occupies 4 bytes instead of 3.
Signed-off-by: Maciej S. Szmigiero mail@maciej.szmigiero.name
include/pcm.h | 20 ++++++++++++++++++-- include/sound/asound.h | 9 +++++++++ src/pcm/pcm.c | 10 ++++++++++ src/pcm/pcm_linear.c | 16 +++++++++++++--- src/pcm/pcm_local.h | 4 ++++ src/pcm/pcm_misc.c | 41 ++++++++++++++++++++++++++++++++++++++--- src/pcm/pcm_plug.c | 11 +++++++++++ src/pcm/pcm_route.c | 6 ++++-- src/pcm/plugin_ops.h | 50 ++++++++++++++++++++++++++++++++++++++++++++++---- 9 files changed, 153 insertions(+), 14 deletions(-)
In my opinion, this patch is enough to discourage reviewers. It's better to split into several patches with proper granularities of topics. For example:
1/5: sync asound.h to recent kernel update (include/sound/asound.h) 2/5: produce new PCM formats to applications (pcm.h, pcm_local.h and pcm_misc.c) 3/5: update plug plugin (pcm_plug.c) 4/5: update linear plugin (pcm_linear.c) 5/5: update route plugin (pcm_route.c)
In general, proper granularity promotes reviewers and even authors to find overlooked mistakes. Please keep it in your mind.
I have split the submission now almost the way you had suggested above - however I have joined the (single) route plugin change to the linear plugin commit since it is the same change as in this plugin and also it is about using a proper conversion method (getput) that this commit had introduced.
Regards
Takashi Sakamoto
Best regards and thanks, Maciej Szmigiero