Re: [PATCH v3 12/12] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document

On Fri, 2022-12-09 at 11:18 +0100, Krzysztof Kozlowski wrote:

On 08/12/2022 04:31, Trevor Wu wrote:

...

Add document for mt8188 board with mt6359.

Signed-off-by: Trevor Wu trevor.wu@mediatek.com

.../bindings/sound/mt8188-mt6359.yaml | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mt8188- mt6359.yaml

diff --git a/Documentation/devicetree/bindings/sound/mt8188- mt6359.yaml b/Documentation/devicetree/bindings/sound/mt8188- mt6359.yaml new file mode 100644 index 000000000000..eac1c87b693a --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml

Missing vendor prefix. You got comments for it already.

Hi Krzysztof,

I will correct it in V4.

...

@@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mt8188-mt635...

+$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;...

+title: MediaTek MT8188 ASoC sound card

+maintainers:

• • Trevor Wu trevor.wu@mediatek.com

+properties:

• compatible:
• const: mediatek,mt8188-mt6359-evb
• model:
• $ref: /schemas/types.yaml#/definitions/string
• description: User specified audio sound card name
• audio-routing:
• $ref: /schemas/types.yaml#/definitions/non-unique-string-array
• description:

•  A list of the connections between audio components. Each
  

entry is a

•  sink/source pair of strings. Valid names could be the input
  

or output

•  widgets of audio components, power supplies, MicBias of
  

codec and the

•  software switch.
  

• mediatek,platform:
• $ref: /schemas/types.yaml#/definitions/phandle
• description: The phandle of MT8188 ASoC platform.
• mediatek,dptx-codec:
• $ref: /schemas/types.yaml#/definitions/phandle
• description: The phandle of MT8188 Display Port Tx codec node.
• mediatek,hdmi-codec:
• $ref: /schemas/types.yaml#/definitions/phandle
• description: The phandle of MT8188 HDMI codec node.

Why you do not use DAI links for all these?

Are the following examples "DAI links" you mean?

hdmi-dai-link { link-name = "HDMI Playback"; cpu { sound-dai = <&q6afedai TERTIARY_MI2S_RX>; };

platform { sound-dai = <&q6routing>; };

codec { sound-dai = <&lt9611_codec 0>; }; };

or

headset-codec { sound-dai = <&rt5682s>; };

As far as I know, only "mediatek,platform" was used at the beginning. Next, hdmi-codec was introduced, and it followed the same style to get phandle. Finally, it became three properties in mt8195, and the implementation of mt8188 was inherited from mt8195.

I just glanced over the usage of dai links. As I see it, I will replace the codec parts with dai link structure like the example above first. It seems to be easier to extend more codecs with the same tyle.

For platform part, I need more time to check if it is better to keep the original implementation, because we still have to take SOF related implementation into consideration.

...

+additionalProperties: false

+required:

• • compatible
• • mediatek,platform

+examples:

• • |

Drop blank line.

OK, I will fix it in V4.

...

• sound: mt8188-sound {

Drop label, not used. Use generic node names, so just "sound".

OK, I will fix it in V4.

Thanks, Trevor

...

•    compatible = "mediatek,mt8188-mt6359-evb";
  

Best regards, Krzysztof