Re: [alsa-devel] [PATCH 05/25] ASoC: soc-component: add snd_soc_component_prepare()

26 Jul 2019


      Hi Cezary
...
...
@@ -774,11 +774,7 @@ static int soc_pcm_prepare(struct snd_pcm_substream *substream)
   for_each_rtdcom(rtd, rtdcom) {
   	component = rtdcom->component;

if (!component->driver->ops ||


    !component->driver->ops->prepare)


	continue;



ret = component->driver->ops->prepare(substream);




snd_soc_component_prepare(component, substream);

if (ret < 0) {
	dev_err(component->dev,
		"ASoC: platform prepare error: %d\n", ret);

Compared to old code, ret gets ignored here. Guess unintended modification?
Thank you for your report.
Yes, I have noticed same issue.
will be fixed at v2
Thank you for your help !!
Best regards
---
Kuninori Morimoto

    