30 Oct
2014
30 Oct
'14
6:06 p.m.
On Thu, Oct 30, 2014 at 10:38:55AM +0530, Vinod Koul wrote:
- ret = sst_prepare_and_post_msg(sst, SST_TASK_ID_MEDIA, IPC_CMD,
IPC_PREP_D3, PIPE_RSVD, 0, NULL, NULL,true, true, false, true);- if (ret < 0) {
dev_err(sst->dev, "not suspending FW!!!");return -EIO;
Better to print and pass back the actual error code we got.
- dev_info(dev, "runtime_suspend called\n");
- if (ctx->sst_state == SST_RESET) {
Drop this down to a dev_dbg() or remove it please (and some others later on).
dev_dbg(dev, "LPE is already in RESET state, No action");
Missing \n.
return 0;- }
- /*save fw context*/
/* Upstream comment style please */