On Fri, 19 Dec 2008 22:08:22 +0800 "ext Stanley.Miao" stanley.miao@windriver.com wrote:
There will be a Oops or frequent underrun messages when playing music with omap soc driver, this is because a data region is incorretly sized, other data region will be overwriten when writing to this data region.
Signed-off-by: Stanley.Miao stanley.miao@windriver.com
sound/soc/omap/omap-pcm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c index ce580a9..2adfbce 100644 --- a/sound/soc/omap/omap-pcm.c +++ b/sound/soc/omap/omap-pcm.c @@ -233,7 +233,7 @@ static int omap_pcm_open(struct snd_pcm_substream *substream) if (ret < 0) goto out;
- prtd = kzalloc(sizeof(prtd), GFP_KERNEL);
- prtd = kzalloc(sizeof(struct omap_runtime_data), GFP_KERNEL);
Oh my... Can you change this as
prtd = kzalloc(sizeof(*prtd), GFP_KERNEL);
like suggested by the CodingStyle and then you can have my ack.
Acked-by: Jarkko Nikula jarkko.nikula@nokia.com