12 Nov
2014
12 Nov
'14
12:52 p.m.
On Wed, Nov 12, 2014 at 10:42:10AM +0200, Peter Ujfalusi wrote:
- if (!handled_mask)
dev_warn(mcasp->dev, "unhandled tx event. txstat: 0x%08x\n",stat);- if (stat & XRERR)
handled_mask |= XRERR;- /* Ack the handled event only */
- mcasp_set_reg(mcasp, DAVINCI_MCASP_TXSTAT_REG, handled_mask);
- return IRQ_HANDLED;
If nothing was handled the driver should be returning IRQ_NONE (I guess saying we handled XRERR is OK, looks like it's an or of the other sources). Either unconditionally ack everything or return IRQ_NONE if the driver doesn't handle anything - the latter option is better and closer to what you have here.