Re: [alsa-devel] [PATCH v8 6/6] ARM: dts: am335x-boneblack: Add HDMI audio support

On Thu, 17 Mar 2016 14:22:34 +0200 Jyri Sarha jsarha@ti.com wrote:

@@ -76,16 +87,22 @@ };

&i2c0 {

• tda19988 {

• tda19988: tda19988 { compatible = "nxp,tda998x"; reg = <0x70>;
• pinctrl-names = "default", "off"; pinctrl-0 = <&nxp_hdmi_bonelt_pins>; pinctrl-1 = <&nxp_hdmi_bonelt_off_pins>;

• port {
  

• 	hdmi_0: endpoint@0 {
  

• 		remote-endpoint = <&lcdc_0>;
  

• #sound-dai-cells = <0>;
  

• audio-ports = <	AFMT_I2S	0x03>;
  

• ports {
  

• 	port@0 {
  

• 		hdmi_0: endpoint@0 {
  

• 			remote-endpoint = <&lcdc_0>;
  

• 		};
  };
  

  }; };

Why did you add a 'ports' container? As there is only one port, it is useless.

Also, you don't need '@0' in the 'port' and 'endpoint'. If you want to keep it, you must add 'reg = 0;'s.