Re: [PATCH] ASoC: dt-bindings: Drop broken irondevice, sma1303 binding

On 01/02/2023 14:10, Krzysztof Kozlowski wrote:

This reverts entire SMA1303 submission:

1. commit 1c24d12b68fa ("ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks")
2. commit dcf6d2ef0e82 ("ASoC: Modified the schema binding and added the vendor prefixes.")
3. commit 5b28c049ff53 ("ASoC: SMA1303: Fix spelling mistake "Invald" -> "Invalid"")
4. commit 68cd394efd0f ("ASoC: The Iron Device SMA1303 is a boosted Class-D audio amplifier.")

Because the binding:

1. Was never tested,
2. Was never sent to Devicetree maintainers,
3. Is entirely broken and wrong, so it would have to be almost rewritten from scratch,
4. It does not match the driver, IOW, the binding is fake.

We cannot accept drivers with broken bindings and make it an ABI.

Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org

I understand that in general we tend to fix, not just to revert. But the poor quality of this binding and the next patch, which was suppose to fix it, plus complete lack of testing, means I do not believe the author will send correct binding.

More over, fixing binding might require dropping incorrect properties, thus changing the driver. I am not willing to do that, I doubt that anyone has the time for it.

It's the job of submitter to work on it.

Best regards, Krzysztof