On Mon, 11 Feb 2019 05:23:36 +0100, Prashant Malani wrote:
Friendly ping.
Since no one raised objection, I applied now.
thanks,
Takashi
On Mon, Feb 4, 2019 at 12:20 PM Prashant Malani pmalani@chromium.org wrote:
Friendly ping. Sounds like Clemens mentioned atoi() should be OK (given his explanation regarding non-numeric strings, along with consistency with the rest of the utility). Are there any other concerns with this patchset?
Thanks once again for taking the time to review.
Best regards,
On Tue, Jan 29, 2019 at 3:42 PM Prashant Malani pmalani@chromium.org wrote:
Interesting. Thanks for pointing that out, Clemens.
In any case, I've sent both versions (atoi v/s strtol), so whichever one is preferred can be used (would be slightly inclined towards atoi, since it's used elsewhere in the file, and because of Clemens' comment; additionally, there is less code duplication with the atoi version).
Best regards,
On Tue, Jan 29, 2019 at 8:19 AM Clemens Ladisch clemens@ladisch.de wrote:
Takashi Sakamoto wrote:
When parsing string with non-numeric characters, the behaviour of atoi() is undefined still in C11.
A completely non-numeric string is specified to return zero.
The behaviour is undefined only if the value cannot be represented, i.e., if it overflows.
Regards, Clemens
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel