On 03/04/2024 18:59, Mighty wrote:
Convert the OMAP4+ McPDM bindings to DT schema.
Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
Signed-off-by: Mighty bavishimithil@gmail.com
Is it your full name?
.../devicetree/bindings/sound/omap-mcpdm.txt | 30 ---------- .../devicetree/bindings/sound/omap-mcpdm.yaml | 58 +++++++++++++++++++ 2 files changed, 58 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/omap-mcpdm.txt create mode 100644 Documentation/devicetree/bindings/sound/omap-mcpdm.yaml
diff --git a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt b/Documentation/devicetree/bindings/sound/omap-mcpdm.txt deleted file mode 100644 index ff98a0cb5..000000000 --- a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt +++ /dev/null @@ -1,30 +0,0 @@ -* Texas Instruments OMAP4+ McPDM
...
diff --git a/Documentation/devicetree/bindings/sound/omap-mcpdm.yaml b/Documentation/devicetree/bindings/sound/omap-mcpdm.yaml new file mode 100644 index 000000000..8c9ff9d90 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/omap-mcpdm.yaml
Filename like compatible.
@@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/omap-mcpdm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: OMAP McPDM
+maintainers:
- Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
+description:
- OMAP ALSA SoC DAI driver using McPDM port used by TWL6040
+properties:
- compatible:
- const: ti,omap4-mcpdm
- reg:
- description: 'Register location and size as an array:
<MPU access base address, size>,<L3 interconnect address, size>;'
Please open existing bindings and look how it is done there.
- interrupts:
- description: Interrupt number for McPDM
Same problem. Drop useless description but provide maxItems.
- ti,hwmods:
- description: Name of the hwmod associated to the McPDM
It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint.
Sorry, this was neither tested nor done in a way matching anything already in the tree. Please do not invent your own style, but open existing binding and look how is it done.
Because of above, I did not perform full review.
- clocks:
- description: phandle for the pdmclk provider, likely <&twl6040>
- clock-names:
- description: Must be "pdmclk"
+required:
- compatible
- reg
- interrupts
- ti,hwmods
- clocks
- clock-names
+additionalProperties: false
+examples:
- |
- mcpdm: mcpdm@40132000 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetre...
Best regards, Krzysztof