-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi Wei,
Thanks for this patch, while I found the other issues in this file. I would like to post new patches instead of yours, later.
Thanks
Takashi Sakamoto o-takashi@sakamocchi.jp
(Jul 20 2014 13:50), weiyj_lk@163.com wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Add the missing unlock before return from function special_clk_ctl_put() in the error handling case.
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn --- sound/firewire/bebob/bebob_maudio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c index 6af50eb..6748515 100644 --- a/sound/firewire/bebob/bebob_maudio.c +++ b/sound/firewire/bebob/bebob_maudio.c @@ -382,8 +382,10 @@ static int special_clk_ctl_put(struct snd_kcontrol *kctl, mutex_lock(&bebob->mutex);
id = uval->value.enumerated.item[0]; - if (id >= ARRAY_SIZE(special_clk_labels)) + if (id >= ARRAY_SIZE(special_clk_labels)) { + mutex_unlock(&bebob->mutex); return 0; + }
err = avc_maudio_set_special_clk(bebob, id, params->dig_in_fmt,