Re: [alsa-devel] [patch] Add support for the new 27 inch IMacs

At Sun, 20 Dec 2009 16:46:15 -0500, Rafael Espíndola wrote:

With the attached patch I am able to use the sound on a new IMac 27. What works:

*) Internal speakers *) Internal microphone *) Headphone

I don't have an external mic or a SPDIF device to test the rest.

The changes look good to me. Just minor issues:

@@ -1103,8 +1107,23 @@ static struct cs_pincfg mbp55_pincfgs[] = { {} /* terminator */ };

+static struct cs_pincfg imac27_pincfgs[] = {

• { 0x09, 0x012b4050},
• { 0x0a, 0x90100140},
• { 0x0b, 0x90100142},
• { 0x0c, 0x018b3020},
• { 0x0d, 0x90a00110},
• { 0x0e, 0x400000f0},
• { 0x0f, 0x01cbe030},
• { 0x10, 0x014be060},
• { 0x12, 0x01ab9070},
• { 0x15, 0x400000f0},

Either put a space around the braces or not. The left and right sides are inconsistent.

Also, don't forget to update Documentation/sound/alsa/HD-Audio-Models.txt, too.

Last but not least, please give your sign-off to merge to the upstream.

Could you fix these and repost?

thanks,

Takashi