Re: [alsa-devel] [PATCH v4 5/5] ASoC: rockchip_max98090: Add HDMI jack support

On Tue, Jul 16, 2019 at 10:16 PM Tzung-Bi Shih tzungbi@google.com wrote:

On Tue, Jul 16, 2019 at 7:58 PM Cheng-Yi Chiang cychiang@chromium.org wrote:

...

diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c index c82948e383da..c81c4acda917 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c +static struct snd_soc_jack rk_hdmi_jack;

+static int rk_hdmi_init(struct snd_soc_pcm_runtime *runtime) +{

•   struct snd_soc_card *card = runtime->card;
  

•   struct snd_soc_component *component = runtime->codec_dai->component;
  

•   int ret;
  

•   /* enable jack detection */
  

•   ret = snd_soc_card_jack_new(card, "HDMI Jack", SND_JACK_LINEOUT,
  

•                               &rk_hdmi_jack, NULL, 0);
  

•   if (ret) {
  

•           dev_err(card->dev, "Can't new HDMI Jack %d\n", ret);
  

•           return ret;
  

•   }
  

•   return hdmi_codec_set_jack_detect(component, &rk_hdmi_jack);
  

+}

In the patch, you should select SND_SOC_HDMI_CODEC, because the patch uses hdmi_codec_set_jack_detect which depends on hdmi-codec.c.

Thanks! I'll fix in v5.