Re: [alsa-devel] [PATCH 2/2] ASoC: codec doc, tlv320aic3x: Add tlv320aic32x4 as compatible

Hi,

On Mon, Jan 13, 2014 at 12:37:21PM +0000, Mark Brown wrote:

On Sat, Jan 11, 2014 at 02:48:31PM +0100, Markus Pargmann wrote:

...

Add tlv320aic32x4 to the compatible list in the binding documentation.

Signed-off-by: Markus Pargmann mpa@pengutronix.de

Documentation/devicetree/bindings/sound/tlv320aic3x.txt | 1 + 1 file changed, 1 insertion(+)

Applied, thanks but you should really also add this compatible string to the driver.

Oh, I didn't notice that the 320aic3x driver actually has of_device_ids. I was using the 320aic3x4 driver which only defines i2c_device_id but it still matches with the compatible fields from my devicetree.

So perhaps it is better to drop this patch as it is no explicit compatible in the driver?

Thanks,

Markus