Re: [alsa-devel] [PATCH 6/9] ASoC: max98095: Add missing negative channel checks

On Wed, Oct 30, 2013 at 08:35:04AM +0100, Takashi Iwai wrote:

• if (channel < 0)

• return channel;
  

  BUG_ON(channel > 1);

This doesn't seem to fit in well with the adjacent code - the handling of out of bounds data isn't consistent though it looks like they're both doing essentially the same thing here.