Re: [alsa-devel] [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:

This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.

There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX, the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather than 'if (PCM_TX == stype)', which makes the codes easy to read.

Signed-off-by: Wan ZongShunmcuos.com@gmail.com

All

Acked-by: Liam Girdwood lrg@slimlogic.co.uk