26 Nov
2008
26 Nov
'08
3:04 p.m.
On Wed, Nov 26, 2008 at 03:48:54PM +0100, Daniel Mack wrote:
- SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
- SOC_DOUBLE_R("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
PGAR_2_HPLOUT_VOL, 0, 0x7f, 1),- SOC_DOUBLE_R("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL, PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
This should be two SOC_DOUBLEs (the end result is the same but that's due to the implementation rather than anything else). Other than that the patch looks fine, though a more verbose patch description describing briefly the routes that are being added (looks like mostly left<->right cross connects?) would be nice.