31 Aug
2017
31 Aug
'17
12:37 p.m.
On Thu, Aug 31, 2017 at 12:23:14PM +0200, Takashi Iwai wrote:
Ah, wait, now I see your point. It was introduced by the very recent patch through Mark's asoc tree (since it was wrongly labeled as "ASoC" while it isn't). That patch looks indeed fishy. The change in atmel_ac97c_resume() is also bad.
The resume check looks fine? The function appears to do nothing other than the clk_prepare_enable().
So, I'd prefer reverting the wrong commit instead, and leave some comment about the uselessness of clk_prepare_enable() return value check.
I'd rather keep the error checking there, it means that people don't need to open the code and verify it when they go scanning for potential problems.