Re: [alsa-devel] [PATCH alsa-lib] Sync enum snd_hwdep_iface_t with include/asound/asound.h

On Aug 18 2014 17:54, Takashi Iwai wrote:

...

diff --git a/include/hwdep.h b/include/hwdep.h index ab12822..6ec421c 100644 --- a/include/hwdep.h +++ b/include/hwdep.h @@ -68,8 +68,13 @@ typedef enum _snd_hwdep_iface { SND_HWDEP_IFACE_USX2Y_PCM, /**< Tascam US122, US224 & US428 raw USB PCM */ SND_HWDEP_IFACE_PCXHR, /**< Digigram PCXHR */ SND_HWDEP_IFACE_SB_RC, /**< SB Extigy/Audigy2NX remote control */

• SND_HWDEP_IFACE_LAST = SND_HWDEP_IFACE_SB_RC /**< last known hwdep interface */

• SNDRV_HWDEP_IFACE_HDA, /* HD-audio */
• SNDRV_HWDEP_IFACE_USB_STREAM, /* direct access to usb stream */
• SNDRV_HWDEP_IFACE_FW_DICE, /* TC DICE FireWire device */
• SNDRV_HWDEP_IFACE_FW_FIREWORKS, /* Echo Audio Fireworks based device */
• SNDRV_HWDEP_IFACE_FW_BEBOB, /* BridgeCo BeBoB based device */

These must be SND_ prefix. And don't forget to have doxygen comments like others. Please submit the fixed patch again.

Oh, indeed. I might lose enough notices when posted... Thanks for your comment.

Regards

Takashi Sakamoto o-takashi@sakamocchi.jp