At Sat, 30 May 2009 23:44:23 +0200, Daniel Mack wrote:
Signed-off-by: Daniel Mack daniel@caiaq.de
You should use strlcpy() instead of strncpy(). The latter doesn't terminate the oversized string.
Takashi
sound/usb/caiaq/device.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c index 7fdecde..f8915a5 100644 --- a/sound/usb/caiaq/device.c +++ b/sound/usb/caiaq/device.c @@ -432,8 +432,8 @@ static int __devinit init_card(struct snd_usb_caiaqdev *dev) if (c) *c = '\0';
- strcpy(card->driver, MODNAME);
- strcpy(card->shortname, dev->product_name);
strncpy(card->driver, MODNAME, sizeof(card->driver));
strncpy(card->shortname, dev->product_name, sizeof(card->shortname));
/* fill card->id with a shortened version of the product string
- which does not contain any whitespaces */
-- 1.6.3.1
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel