13 Nov
2023
13 Nov
'23
11:04 a.m.
Hi Andy!
On Mon, 2023-11-13 at 11:59 +0200, Andy Shevchenko wrote:
On Sat, Nov 11, 2023 at 8:18 PM Alexander Sverdlin alexander.sverdlin@gmail.com wrote:
On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote:
...
[1]
+ mdelay(1000);
Atomic?! Such a huge delay must be explained, esp. why it's atomic.
atomic or not, SoC is supposed to reset itself here. However there is an errata [1] and the SoC can lockup instead.
Good, and what I'm saying is that this piece of code must have a comment explaining this.
And it has, but for some reason you've trimmed it in your reply...
--
Alexander Sverdlin.