20 Mar
2012
20 Mar
'12
4:50 p.m.
On Tue, Mar 20, 2012 at 05:03:47PM +0530, Rajeev Kumar wrote:
This patch add support for the SPEAr ASoC pcm layer in ASoC framework.
This should really be rewritten in terms of the dmaengine helper library which Lars-Peter contributed for 3.4. It looks like you're not using cyclic mode here which is currently a requirement for the library - if your hardware doesn't have cyclic support then that'll need to be added.
We've already got too many independant implementations of an ALSA to dmaengine mapping, we should be cutting down on the amount of code as much as possible in order to avoid code duplication and make sure that we're able to roll out good practice and new features as easily as possible.