Re: [alsa-devel] [PATCH] sound/soc/mxs/mxs-saif.c: add missing kfree

22 Aug 2011


      On 21/08/11 12:18, Julia Lawall wrote:
...
From: Julia Lawall julia@diku.dk
Move the test on pdev->id before the kzalloc to avoid requiring kfree when
the test fails.  This fix was suggested by Wolfram Sang.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@
(
if (...) { ... when != kfree(x)
               when != x = E3
               when != E3 = x

return ...;

}
... when != x = E2
    when != I(...,x,...) S
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>
Signed-off-by: Julia Lawall julia@diku.dk
Acked-by: Liam Girdwood lrg@ti.com