On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote:
On Tue, Aug 28, 2012 at 05:13:05PM +0200, Janusz Krzysztofik wrote:
On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote:
On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote:
- platform_set_drvdata(ams_delta_audio_platform_device,
&ams_delta_audio_card);The real fix here is that you should be using platform data here,
not
driver data. Is there some reason not to do that?
Do you think the change you propose is suitable for the rc cycle?
I'm
trying to fix a regression in the first place. Converting the ams-
delta
asoc to a platform driver is on my todo list and I'm going to take
care
of this as soon as I have enough spare time.
The above looks like you already have a platform driver? All I'm suggesting is changing the above to use platform rather than driver data.
The ams-delta asoc driver doesn't use snd_soc_register_card() so far, but relays solely on soc_probe() doing this for it, which in turn expects to find a snc_soc_card structure in drvdata. How is it supposed to find that structure if I pass it over platform data instead? Am I missing something?
Thanks, Janusz