On 09/07/2025 02:12, ew kim wrote:
Add soundcard bindings for the abox generic of exynus automotive.
This wasn't ever tested, so very short review. You have typos here and there. But more important - this should not be a "generic" thing, but binding for your sound card.
What's more important, there is no user of it, so anyway this cannot be accepted as it makes no sense without user.
Signed-off-by: ew kim ew.kim@samsung.com
.../bindings/sound/samsung,abox-generic.yaml | 77 +++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml
diff --git a/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml new file mode 100644 index 000000000000..bf641a197903 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/samsung/abox-generic.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
But the quality of the patch and lack of testing makes me thinking if you could not get some help inside Samsung in posting a proper patch?
Best regards, Krzysztof