22 Feb
2013
22 Feb
'13
5:18 p.m.
At Fri, 22 Feb 2013 17:12:36 +0100, Daniel Mack wrote:
- ret = hiface_pcm_init(chip, quirk ? quirk->extra_freq : 0);
- if (ret < 0)
goto err_chip_destroy;- ret = snd_card_register(chip->card);
- if (ret < 0) {
snd_printk(KERN_ERR "cannot register " CARD_NAME " card\n");Not sure, but I think it might be better to use dev_{err,info,dgb} here, so the logging can be grouped to individual devices. Takashi, any opinion on that?
Yeah, I think we should move to dev_*() somehow. At least, for most of generic outputs with snd_printk() can be converted with more standard functions. It's fine that a new driver starts using dev_*(), then we'll convert the old ones eventually later.
Debug prints with snd_printd() or snd_printdd() are different questions, though. We have another control factor over the behavior of these functions, so conversions should be done carefully.
Takashi