If uda134x_soc_probe fail with unknown codec type, it should properly free allocated memory before return -EINVAL.
Signed-off-by: Axel Lin axel.lin@gmail.com --- This case won't be executed in current implementation because there is a model checking in the begin of uda134x_soc_probe. But since the code is there, I think it's good to make it correct. Otherwise, we can simply remove the default case.
sound/soc/codecs/uda134x.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/uda134x.c b/sound/soc/codecs/uda134x.c index 28aac53..9bff3c6 100644 --- a/sound/soc/codecs/uda134x.c +++ b/sound/soc/codecs/uda134x.c @@ -566,9 +566,10 @@ static int uda134x_soc_probe(struct platform_device *pdev) ARRAY_SIZE(uda1345_snd_controls)); break; default: + ret = -EINVAL; printk(KERN_ERR "%s unknown codec type: %d", __func__, pd->model); - return -EINVAL; + break; }
if (ret < 0) {