On Mon, Jan 07, 2019 at 11:32:48AM +0100, Jaroslav Kysela wrote:
Dne 6.1.2019 v 04:47 russell.parker7@gmail.com napsal(a):
Hi,
When I submitted a patch to create a UCM config for chtrt5650 it was suggested that I also factor out command sequences that it shares with chtrt5645. The following patchset introduces a new component directory codecs/rt5645-common/ and refactors UCM profiles in:
- chtrt5645
- chtrt5645-mono-speaker-analog-mic
- chtrt5650
- ASUSTeKCOMPUTERINC.-T100HAN-1.0-T100HAN
- LENOVO-80XF-LenovoMIIX320_10ICR-LNVNB161216
I compiled and tested playback with the rt5650 configs but I don't have the devices to test the other configurations. Suggestions and feedback are welcome, I'm not very familiar with UCM configuration so there may definitely be better approaches for some of these changes.
Thanks. I applied your changes to the alsa-lib's repo with only one minor modification - I changed rt5645-common directory name to rt5645. I don't see the reason to explicitly say that it's common code. All configs in the codecs/ tree are common, don't they?
I went with rt5645-common/ because it's common across multiple codecs -- the rt5650 chips are a lower-cost version of the rt5645 so I reused components from the shared folder for the chtrt5650 conf too. Apparently, the alc3278 may be similar to the rt5650 as Bossart mentioned in the earlier thread "Add UCM config for chtrt5650", so if UCM support is added the same sequences could be potentially used for that too.
Anyway, that was the naming motivation, but I'm not too picky.
Thanks!
- Russell
Jaroslav-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.