On Fri, Oct 12, 2018 at 09:28:56AM -0700, Vasily Khoruzhick wrote:
On Friday, October 12, 2018 9:09:05 AM PDT Mark Brown wrote:
On Fri, Oct 12, 2018 at 08:32:54AM -0700, Vasily Khoruzhick wrote:
Otherwise we may end up with shutting down I2S if shutdown() was called for capture substream, but playback is still running.
Would it be cleaner and more robust to use runtime PM? I'm wondering what happens if some of the configuration stuff turns out to also need some of the clocks for example.
I guess. I'm not sure why this code was put into startup and shutdown callbacks in first place.
Maybe Marcus or Maxime know?
As for configuration - only bus clock is necessary for configuration and it's already enabled in runtime_resume() callback.
Probably these really are only needed when audio is active so it's saving that little bit of power in which case your fix looks good to me but I'll leave a chance for the people with system specific knowledge to review.