Hi Andy
Thanks for your comments, answer in line:
From: Andy Shevchenko andriy.shevchenko@linux.intel.com Sent: 30 April 2024 21:45 To: Takashi Iwai Cc: Xu, Baojun; robh+dt@kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com; Lu, Kevin; Ding, Shenghao; Navada Kanyana, Mukund; 13916275206@139.com; P O, Vijeth; Holalu Yogendra, Niranjan; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; liam.r.girdwood@intel.com; yung-chuan.liao@linux.intel.com; broonie@kernel.org; soyer@irl.hu Subject: [EXTERNAL] Re: [PATCH v4 1/3] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI
On Tue, Apr 30, 2024 at 02: 58: 10PM +0200, Takashi Iwai wrote: > On Tue, 30 Apr 2024 09: 25: 42 +0200, Baojun Xu wrote: .. . > > snd-hda-cs-dsp-ctls-objs := hda_cs_dsp_ctl. o > > snd-hda-scodec-component-objs := hda_component. o > ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas Instruments. Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to phishing@list.ti.com
ZjQcmQRYFpfptBannerEnd
On Tue, Apr 30, 2024 at 02:58:10PM +0200, Takashi Iwai wrote:
On Tue, 30 Apr 2024 09:25:42 +0200, Baojun Xu wrote:
...
snd-hda-cs-dsp-ctls-objs := hda_cs_dsp_ctl.o snd-hda-scodec-component-objs := hda_component.o snd-hda-scodec-tas2781-i2c-objs := tas2781_hda_i2c.o +snd-hda-scodec-tas2781-spi-y := tas2781_hda_spi.o tas2781_spi_fwlib.o
A nitpicking: better to align with other lines (i.e. with *-objs instead of *-y).
I object this. The better approach is to have a precursor patch that switches to y over objs (the latter is for user space code / tools).
I also do not fully understand why set it as "y", as you know, I follow CONFIG_SND_HDA_SCODEC_TAS2781_I2C, as it do not set to "y".
-- With Best Regards, Andy Shevchenko